Hi Henrik,
On Fri, 2024-08-02 at 19:31 +0200, Henrik Grimler wrote: [snip]
The exynos_hs_i2c driver no longer compiles for exynos4 or exynos5 with these changes, I am getting (with for example `make odroid-xu3_defconfig; make`):
CC drivers/i2c/exynos_hs_i2c.o ../drivers/i2c/exynos_hs_i2c.c: In function 'hsi2c_get_clk_details': ../drivers/i2c/exynos_hs_i2c.c:154:17: warning: implicit declaration of function 'get_i2c_clk'; did you mean 'get_tbclk'? [-Wimplicit- function-declaration] 154 | clkin = get_i2c_clk(); | ^~~~~~~~~~~ | get_tbclk ../drivers/i2c/exynos_hs_i2c.c: In function 's3c_i2c_of_to_plat': ../drivers/i2c/exynos_hs_i2c.c:543:23: warning: implicit declaration of function 'pinmux_decode_periph_id' [-Wimplicit-function- declaration] 543 | i2c_bus->id = pinmux_decode_periph_id(blob, node); | ^~~~~~~~~~~~~~~~~~~~~~~ ../drivers/i2c/exynos_hs_i2c.c:553:9: warning: implicit declaration of function 'exynos_pinmux_config' [-Wimplicit-function-declaration] 553 | exynos_pinmux_config(i2c_bus->id, PINMUX_FLAG_HS_MODE); | ^~~~~~~~~~~~~~~~~~~~ ../drivers/i2c/exynos_hs_i2c.c:553:43: error: 'PINMUX_FLAG_HS_MODE' undeclared (first use in this function) 553 | exynos_pinmux_config(i2c_bus->id, PINMUX_FLAG_HS_MODE); | ^~~~~~~~~~~~~~~~~~~ ../drivers/i2c/exynos_hs_i2c.c:553:43: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [../scripts/Makefile.build:257: drivers/i2c/exynos_hs_i2c.o] Error 1 make[2]: *** [../scripts/Makefile.build:397: drivers/i2c] Error 2 make[1]: *** [/mnt/linux/Makefile:1895: drivers] Error 2
Woops, stupid mistake, sending v2 soon which does actually compile on exynos4/5 too. Should work fine with that, but trying it would be appreciated.
Best regards, Henrik Grimler
Best regards, David