-----Original Message----- From: Anup Patel anup@brainfault.org Sent: 25 January 2020 14:12 To: Jagan Teki jagan@amarulasolutions.com Cc: Pragnesh Patel pragnesh.patel@sifive.com; Atish Patra atish.patra@wdc.com; Palmer Dabbelt palmerdabbelt@google.com; U- Boot-Denx u-boot@lists.denx.de Subject: Re: [PATCH v3 07/10] configs: fu540: Add config file for U-boot SPL
On Fri, Jan 24, 2020 at 12:21 PM Jagan Teki jagan@amarulasolutions.com wrote:
On Fri, Jan 24, 2020 at 11:21 AM Pragnesh Patel pragnesh.patel@sifive.com wrote:
With sifive_fu540_spl_defconfig:
U-Boot SPL will be loaded by ZSBL from SD card (replace fsbl.bin with u-boot-spl.bin) and runs in L2 LIM in machine mode and then load FIT image u-boot.itb from 1st partition of SD card (replace fw_payload.bin with u-boot.itb) into RAM.
U-boot SPL expects u-boot.itb FIT image in the 1st partition of SD card irrespective of GUID
Signed-off-by: Pragnesh Patel pragnesh.patel@sifive.com
I'm thinking we don't need any separate config for SPL. Say if we have single config that creates both SPL and U-Boot proper and give feasibility to the user to use
- SPL + U-Boot proper
- SiFive SPL + U-Boot proper
We are using a similar approach for other platforms, I guess the same will valid here, any comments?
I agree with Jagan.
We can augment all required SPL related config options directly in sifive_fu540_defconfig but we have to ensure that u-boot.bin created with updated sifive_fu540_defconfig works fine with OpenSBI FW_PAYLOAD.
If SPL related configs will be included in sifive_fu540_defconfig then the generated u-boot.bin works fine with OpenSBI FW_PAYLOAD.
There are 2 cases: 1) Without U-boot SPL - FSBL + OpenSBI fw_payload + U-boot proper works.
2) With U-boot SPL - SPL + FW_DYNAMIC + U-boot proper works.
Will include SPL related configs in sifive_fu540_defconfig in v4. Any comments?
Regards, Anup