Dne torek, 19. januar 2021 ob 02:05:20 CET je Andre Przywara napisal(a):
The #ifdef CONFIG_xxxPWR conditionals were not working as expected, as string Kconfig symbols are always "defined" from the preprocessor's perspective. This lead to unnecessary calls to the GPIO routines, but also always added a half a second delay to wait for a SATA disk to power up. Many thanks to Peter for pointing this out!
Fix this by properly comparing the Kconfig symbols against the empty string. strcmp() would be nicer for this, but GCC does not optimise this away, probably due to our standalone compiler switches.
Reported-by: Peter Robinson pbrobinson@gmail.com Signed-off-by: Andre Przywara andre.przywara@arm.com
Nice find!
Reviewed-by: Jernej Skrabec jernej.skrabec@siol.net
Best regards, Jernej