Re: [PATCH v2 12/13] tpm: Add a driver for H1/Cr50

Hi,

On Sat, 21 Dec 2019 at 11:17, Simon Glass sjg@chromium.org wrote:

H1 is a Google security chip present in recent Chromebooks, Pixel phones and other devices. Cr50 is the name of the software that runs on H1 in Chromebooks.

This chip is used to handle TPM-like functionality and also has quite a few additional features.

Add a driver for this.

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v2:

• Significant rewrite of cr50 init procedure
• Support use of interrupts

drivers/tpm/Kconfig | 10 + drivers/tpm/Makefile | 1 + drivers/tpm/cr50_i2c.c | 661 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 672 insertions(+) create mode 100644 drivers/tpm/cr50_i2c.c

I see that I did not make the timeout changes mentioned in the v1 patch.

I'm actually not sure they are an improvement.

Regards, Simon