19 Dec
2014
19 Dec
'14
5:31 p.m.
Hi Guido,
thanks for your feedback!
On 12/19/2014 05:27 PM, Guido MartÃnez wrote:
+/**
- omap_prefetch_enable - configures and starts prefetch transfer
- @fifo_th: fifo threshold to be used for read/ write
- @count: number of bytes to be transferred
- @is_write: prefetch read(0) or write post(1) mode
- */
+static int omap_prefetch_enable(int fifo_th, unsigned int count, int is_write) +{
- uint32_t val;
- if (fifo_th > PREFETCH_FIFOTHRESHOLD_MAX)
return -EINVAL;- if (readl(&gpmc_cfg->prefetch_control))
return -EBUSY;- /* Set the amount of bytes to be prefetched */
- writel(count, &gpmc_cfg->prefetch_config2);
- val = (cs << PREFETCH_CONFIG1_CS_SHIFT) | (is_write & 1) |
On a current U-boot "cs" doesn't exist. I think you might want to pass a "struct omap_nand_info *" and use info->cs.
I fixed this last bit, and tested it. It results in 2.5x speed improvements on a Micron NAND. So, thanks :) !
If you resend, you have my Reviewed-by and Tested-by.
That's great to hear. However, I'm not currently working on this project, so I don't have a chance to respin the patch. In case any of the maintainers is interested, I guess that's easy enough to tweak on the fly when merging the patch :)
Thanks, Daniel