Re: [U-Boot] [PATCH 2/2] ehci-hcd.c, musb_core, usb.h: Add USB_DMA_MINALIGN define for cache alignment

15 Jul 2012


      Hi,
On Sun, Jul 8, 2012 at 7:08 AM, Marek Vasut marex@denx.de wrote:
...
@@ -207,8 +210,8 @@ static int
 ehci_submit_async(struct usb_device *dev, unsigned long pipe, void
*buffer,
                   int length, struct devrequest *req)
 {

  static struct QH qh __attribute__((aligned(32)));


  static struct qTD qtd[3] __attribute__((aligned (32)));




  ALLOC_CACHE_ALIGN_BUFFER(struct QH, qh, 1);




Somehow this doesn't work being allocated on stack... I assumed that this
was declared as static just to use __attribute__((aligned))... but it seems
that current code doesn't like qh address being changed (I'm getting "Timed
out on TD" messages). Any ideas? Changing it to DEFINE_... seems to help
but it looks like hiding another bug.
Regards, Ilya.

    

Ilya Yanok