On Wed, 2008-01-02 at 07:13, Jerry Van Baren wrote:
Yes, nested comments is something that should not be done and should be fixed. This was inherited from the original code, although the current version uses // for the embedded comment which avoids the issue (but causes "no C++ comments" people to break out in rashes).
Woah, hey! That's me!
Uh...
Hmm, interesting, the original appears to have always used //, so it would appear that we (u-booties) did the change to /* */. http://jdl.com/git_repos/?p=dtc.git;a=commitdiff;h=53acf491e9d576519f97b62984762498f9453cb4 I'll have to look at this further.
My inclination is to change to embedded // comments to avoid drifting from the original due to aesthetics rather than due to necessary functionality differences.
The alternative would be to convince David Gibson (/jdl) to adopt the ...other code here... change. I prefer the ... change if it matters - if somebody blindly cuts and pastes the example code, it won't compile until he understands and edits what he pasted.
Oh man....
OK. For the record, I'm all for only comments like this:
/* * */
Clearly lax, I'll start enforcing it on the DTC sources more.
Sorry.
jdl