Re: [PATCH] tools: fdtgrep: Use unsigned chars for arrays

16 Mar 2021


      On Wed, 10 Feb 2021 at 17:43, Samuel Dionne-Riel samuel@dionne-riel.com wrote:
...
Otherwise, values over 127 end up prefixed with ffffff.
Signed-off-by: Samuel Dionne-Riel samuel@dionne-riel.com
Cc: Simon Glass sjg@chromium.org

Minimal reproduction:
// repro.dts
/dts-v1/;

/ {
    ra = [ 7f ];
    rb = [ 80 ];
};

Steps used to compile:
$ dtc repro.dts > repro.dtb
Without the fix:
$ fdtgrep --include-node / repro.dtb
/ {
    ra = [7f];
    rb = [ffffff80];
};
With the fix:
$ fdtgrep --include-node / repro.dtb
/ {
    ra = [7f];
    rb = [80];
};

tools/fdtgrep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org
Applied to u-boot-dm/next, thanks!