On Sat 2014-11-15 22:29:00, Marek Vasut wrote:
On Saturday, November 15, 2014 at 08:54:06 PM, Pavel Machek wrote:
On Fri 2014-11-14 21:02:48, Marek Vasut wrote:
On Friday, November 14, 2014 at 11:23:27 AM, Pavel Machek wrote:
On Thu 2014-11-13 11:23:41, dinguyen@opensource.altera.com wrote:
From: Dinh Nguyen dinguyen@opensource.altera.com
Set the PHY skew settings for the ethernet phy on the SOCFPGA Cyclone5 hardware.
Is it to need similar settings for all ksz9021 phys? Should this go to drivers/ as I suggested with a patch?
This is board specific, but with the driver model, this should be moved into the PHY driver and the values should be passed via platform data or DT.
I will apply this now, since it fixes real issue.
Hmm, could you apply the patch I posted, instead? It has configuration in socfpga_config.h -- "platform data".
Hi!
The patch you provided (if we're referring to the same patch, Message-ID: 20141113120956.GB30779@amd) breaks every board which uses the Micrel PHY, doesn't it ? The problem for all other boards would be the new CONFIG_* options which are added into the Micrel driver by that patch. Furthermore, the patch doesn't even apply, it was decided that the patch was an RFC, wasn't it ? Please correct me if I'm wrong.
The purpose of that mail was to show that there's better way, so that someone (you) would not apply bandaid when something close to real fix is available.
I overlooked the "breaks compilation" part, but I'm sure it could have been solved with strategicaly placed #ifdef. Notice original patch submission in
From pavel@denx.de Sat Oct 25 13:27:52 2014
Date: Sat, 25 Oct 2014 13:27:52 +0200 From: Pavel Machek pavel@denx.de Subject: [patch] net: micrel: configure skew values for Message-ID: 20141025112752.GA19599@amd
it is cleaner then 20141113120956.GB30779@amd version. I don't think I received any reply there.
But the patch you have just merged would interfere with my approach, and makes it unneccessary, so I'll let you solve it.
Best regards, Pavel