Re: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD

On 02:17 Thu 23 Jul , Ilya Yanok wrote:

Hi Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:

...

...

+static int imx27lite_devices_init(void) +{

• struct gpio_regs *regs = (struct gpio_regs *)IMX_GPIO_BASE;
• int i;
• unsigned int mode[] = {

• PD0_AIN_FEC_TXD0,
  

• PD1_AIN_FEC_TXD1,
  

• PD2_AIN_FEC_TXD2,
  

• PD3_AIN_FEC_TXD3,
  

• PD4_AOUT_FEC_RX_ER,
  

• PD5_AOUT_FEC_RXD1,
  

• PD6_AOUT_FEC_RXD2,
  

• PD7_AOUT_FEC_RXD3,
  

• PD8_AF_FEC_MDIO,
  

• PD9_AIN_FEC_MDC | GPIO_PUEN,
  

• PD10_AOUT_FEC_CRS,
  

• PD11_AOUT_FEC_TX_CLK,
  

• PD12_AOUT_FEC_RXD0,
  

• PD13_AOUT_FEC_RX_DV,
  

• PD14_AOUT_FEC_CLR,
  

• PD15_AOUT_FEC_COL,
  

• PD16_AIN_FEC_TX_ER,
  

• PF23_AIN_FEC_TX_EN,
  

• PE12_PF_UART1_TXD,
  

• PE13_PF_UART1_RXD,
  

• PB4_PF_SD2_D0,
  

• PB5_PF_SD2_D1,
  

• PB6_PF_SD2_D2,
  

• PB7_PF_SD2_D3,
  

• PB8_PF_SD2_CMD,
  

• PB9_PF_SD2_CLK,
  

• (GPIO_PORTC | GPIO_OUT | GPIO_PUEN | GPIO_GPIO | 31),
  

• };
• for (i = 0; i < ARRAY_SIZE(mode); i++)

• imx_gpio_mode(mode[i]);
  
  

you do not answer about my api comment?

Sorry, I forgot to write a separate mail to ask you.

...

do you plan to create one for device init?

What kind of API you expect me to create here? It's just IO pins initialization...

do as at91, davinci all related init for rs232, usb, net in one function per init

Best Regards, J.