Dear Stefan Roese,
Hi Stefano,
On 25.04.2013 09:31, Stefano Babic wrote:
On 24/04/2013 12:59, Benoît Thébaudeau wrote:
Apart of that and not related to this patch, if we in future use SPL also for booting from SD, we can get a single way to boot from different storage. TI based SOCs already do this: same SPL, it checks from SD and NAND.
With this also comes the issue of BOOT_FROM in board/denx/m53evk/imximage.cfg. Strictly speaking, in order to be correct, it should be #if-ed depending on some config option: nand or sd.
Right, this is also correct. Anyway, BOOT_FROM is used to get the offset inside the storage, and only to be as much flexible as possible, each storage has defined its own offset. However, Freescale uses the same offset (0x400) for most storages (NAND, SD..) and another one for NOR or OneNAND (0x1000). Maybe it is easier to have only this two cases.
Yes, I would prefer that.
And being at it, why don't we add the offset to the resulting image as well? This would make programming the images to the destination (SD, NAND, MMC etc) easier. We would not have to care for the correct offset then (which is more error prone). And it is necessary btw, to have this offset added, when using the FSL kobs-ng tool to program the image to NAND flash.
This would interfere with MBR on SD cards, the offset is there for a reason ;-)
Best regards, Marek Vasut