Hi
I think I do this modify for those soc not have TPL, or else it will cause the CI build error.
TPL/ddr binary is mandatory in all rockchip SoCs now, but the mainline U-Boot may not
able to provide the the available TPL, will need ddr init binary from rockchip rkbin repository
instead.
So the policy is clear, the binary output on mainline U-Boot rockchip platform:
- TPL available: u-boot-rockchip.bin with TPL, SPL, ATF, U-Boot proper;
- TPL not available: u-boot.itb with ATF, U-Boot proper.
idbloader.bin generate by the TPL(ddr init binary instead) and SPL via mkimage cmd;
Thanks, - Kever On 2023/1/27 15:21, Jagan Teki wrote:
This reverts commit f5315dd6290a588434e4f79bfd2886bb7df9210d.
[why] TPL is not mandatory for not all Rockchip SoCs, some SoCs like RK356x, and RK3588 still use mainline u-boot without TPL as their ddr init programs are accessed via binaries provided by Rockchip instead of ddr source code.
Marking TPL build makes it not able to build u-boot.itb on RK356x targets so revert this so that it can build an SPL build that would support all across Rockchip platforms.
Suggested-by: Quentin Schulz quentin.schulz@theobroma-systems.com Signed-off-by: Jagan Teki jagan@edgeble.ai
arch/arm/dts/rockchip-u-boot.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/rockchip-u-boot.dtsi b/arch/arm/dts/rockchip-u-boot.dtsi index 234fc5df43..6d1fd7769e 100644 --- a/arch/arm/dts/rockchip-u-boot.dtsi +++ b/arch/arm/dts/rockchip-u-boot.dtsi @@ -11,7 +11,7 @@ }; };
-#ifdef CONFIG_TPL +#ifdef CONFIG_SPL &binman { simple-bin { filename = "u-boot-rockchip.bin";