Re: [PATCH u-boot-marvell v3 25/39] tools: kwbimage: Update comments describing kwbimage v1 structures

On 24.09.21 23:07, Marek Behún wrote:

From: Pali Rohár pali@kernel.org

These structures are relevant for several other platforms, mention them all.

Signed-off-by: Pali Rohár pali@kernel.org Signed-off-by: Marek Behún marek.behun@nic.cz

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan

---

tools/kwbimage.c | 3 ++- tools/kwbimage.h | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/tools/kwbimage.c b/tools/kwbimage.c index d1f4f93e0f..77bf4dd886 100644 --- a/tools/kwbimage.c +++ b/tools/kwbimage.c @@ -1,7 +1,8 @@ // SPDX-License-Identifier: GPL-2.0+ /*

• Image manipulator for Marvell SoCs

• • supports Kirkwood, Dove, Armada 370, Armada XP, and Armada 38x

• • supports Kirkwood, Dove, Armada 370, Armada XP, Armada 375, Armada 38x and
• • Armada 39x
  • (C) Copyright 2013 Thomas Petazzoni
  • thomas.petazzoni@free-electrons.com

diff --git a/tools/kwbimage.h b/tools/kwbimage.h index 56a748d4cf..679c454367 100644 --- a/tools/kwbimage.h +++ b/tools/kwbimage.h @@ -69,7 +69,7 @@ struct ext_hdr_v0 { uint8_t checksum; } __packed;

-/* Structure of the main header, version 1 (Armada 370/38x/XP) */ +/* Structure of the main header, version 1 (Armada 370/XP/375/38x/39x) */ struct main_hdr_v1 { uint8_t blockid; /* 0x0 */ uint8_t flags; /* 0x1 */ @@ -103,7 +103,7 @@ struct main_hdr_v1 { #define MAIN_HDR_V1_OPT_BAUD_115200 0x7

/*

• • Header for the optional headers, version 1 (Armada 370, Armada XP)

• • Header for the optional headers, version 1 (Armada 370/XP/375/38x/39x)
  */ struct opt_hdr_v1 { uint8_t headertype;

@@ -127,7 +127,7 @@ struct sig_v1 { } __packed;

/*

• • Structure of secure header (Armada 38x)

• • Structure of secure header (Armada XP/375/38x/39x)
  */ struct secure_hdr_v1 { uint8_t headertype; /* 0x0 */

Viele Grüße, Stefan