On Tuesday 09 December 2008, Eibach, Dirk wrote:
It's really not a big deal, but since I addressed these issues in my last mail again, I noticed them in this version as well.
<snip>
+#define CONFIG_SYS_SDRAM0_TR0 0x410a4012 +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000
Oops. Sorry. I thought I had eliminated all of those nasty buggers. If I ever get to talk to the person I copied that stuff from... :)
Heh. OK, got me. I most likely copied this stuff from another config as well. Only the review process was much more superficially at that time, so it must have slipped though. Please feel free to submit another patch to clean up other config headers as well. :)
Tab after #define! You seem to have missed this one. Did you ever try running checkpatch on your patch? This should spot such problems.
In fact my version of checkpatch (linux 2.6.27) does not :( That is why the last one slipped through. Which version of checkpatch are you using?
I didn't really check if checkpatch complains about this. I only thought it does. Must have been mistaken though.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================