Re: [U-Boot] [PATCHv2] ARM: socfpga: add support for IS1 board

Hi!

...

--- /dev/null +++ b/arch/arm/dts/socfpga_cyclone5_is1.dts @@ -0,0 +1,109 @@ +/*

• • Copyright (C) 2012 Altera Corporation <www.altera.com>

This copyright notice needs to be updated.

How? dts is probably not copyrightable, and my changes are certainly not complex enough for copyright protection.

...

+/* Extra Environment */ +#define CONFIG_EXTRA_ENV_SETTINGS \

• "verify=n\0" \
• "loadaddr=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \

This loadaddr is set by CONFIG_LOADADDR (above)

I'm not sure what you are trying to tell me, in any case socfpga_sr1500.h has same entry.

...

• "ramboot=setenv bootargs " CONFIG_BOOTARGS ";" \

• "bootm ${loadaddr} - ${fdt_addr}\0" \
  

• "bootimage=zImage\0" \
• "fdt_addr=100\0" \
• "fdtimage=socfpga.dtb\0" \
• "bootm ${loadaddr} - ${fdt_addr}\0" \
• "mmcroot=/dev/mmcblk0p2\0" \
• "mmcboot=setenv bootargs " CONFIG_BOOTARGS \

• " root=${mmcroot} rw rootwait;" \
  

• "bootz ${loadaddr} - ${fdt_addr}\0" \
  

• "mmcload=mmc rescan;" \

• "load mmc 0:1 ${loadaddr} ${bootimage};" \
  

• "load mmc 0:1 ${fdt_addr} ${fdtimage}\0" \
  

• "qspiload=sf probe && mtdparts default && run ubiload\0" \
• "qspiboot=setenv bootargs " CONFIG_BOOTARGS \

• " root=${qspiroot} rw rootfstype=${qspirootfstype};"\
  

• "bootm ${loadaddr} - ${fdt_addr}\0" \
  

• "uboot_env_complete=yes\0"

Can we drop this extra environment? It looks like a copy of the CV SoCDK env, which is broken nonetheless, so unless it's used, drop it in V3 please.

We can drop the extra environment for now.

Best regards, Pavel