On 03/15/2016 03:23 AM, Peng Fan wrote:
Support Driver Model for fsl esdhc driver.
- Introduce a new structure struct fsl_esdhc_priv
- Refactor fsl_esdhc_initialize which is originally used by board code.
- Introduce fsl_esdhc_init to be common usage for DM and non-DM
- Introduce fsl_esdhc_cfg_to_priv to build the bridge for non-DM part.
- The original API for board code is still there, but we use 'fsl_esdhc_cfg_to_priv' and 'fsl_esdhc_init' to serve it.
- All the functions are changed to use 'struct fsl_esdhc_priv', except fsl_esdhc_initialize.
- Since clk driver is not implemented, use mxc_get_clock to geth the clk and fill 'priv->sdhc_clk'.
Has been tested on i.MX6UL 14X14 EVK board: " =>dm tree .... simple_bus [ + ] | `-- aips-bus@02100000 mmc [ + ] | |-- usdhc@02190000 mmc [ + ] | |-- usdhc@02194000 .... => mmc list FSL_SDHC: 0 (SD) FSL_SDHC: 1 (SD) "
Signed-off-by: Peng Fan van.freenix@gmail.com Cc: York Sun york.sun@nxp.com Cc: Yangbo Lu yangbo.lu@nxp.com Cc: Hector Palacios hector.palacios@digi.com Cc: Eric Nelson eric@nelint.com Cc: Stefano Babic sbabic@denx.de Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Pantelis Antoniou panto@antoniou-consulting.com Cc: Simon Glass sjg@chromium.org
V2: restructure the V1 patch. Introduce fsl_esdhc_priv structure. Introduce code to handle cd-gpios and non-removable.
drivers/mmc/fsl_esdhc.c | 253 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 213 insertions(+), 40 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index ea5f4bf..6fadde1 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -20,6 +20,9 @@
<snip>
+static int fsl_esdhc_probe(struct udevice *dev) +{
- struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);
- struct fsl_esdhc_priv *priv = dev_get_priv(dev);
- const void *fdt = gd->fdt_blob;
- int node = dev->of_offset;
- fdt_addr_t addr;
- unsigned int val;
- int ret;
- addr = dev_get_addr(dev);
- if (addr == FDT_ADDR_T_NONE)
return -EINVAL;- priv->esdhc_base = (phys_addr_t)addr;
- priv->dev = dev;
- val = fdtdec_get_int(fdt, node, "bus-width", -1);
- if (val == 8)
priv->bus_width = 8;- else if (val == 4)
priv->bus_width = 4;- else
priv->bus_width = 1;- if (fdt_get_property(fdt, node, "non-removable", NULL)) {
priv->non_removable = 1;} else {priv->non_removable = 0;gpio_request_by_name_nodev(fdt, node, "cd-gpios", 0,&priv->cd_gpio, GPIOD_IS_IN);- }
- /*
* TODO:* Because lack of clk driver, if SDHC clk is not enabled,* need to enable it first before this driver is invoked.** we use MXC_ESDHC_CLK to get clk freq.* If one would like to make this function work,* the aliases should be provided in dts as this:** aliases {* mmc0 = &usdhc1;* mmc1 = &usdhc2;* mmc2 = &usdhc3;* mmc3 = &usdhc4;* };* Then if your board only supports mmc2 and mmc3, but we can* correctly get the seq as 2 and 3, then let mxc_get_clock* work as expected.*/- priv->sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK + dev->seq);
Peng,
This seems to be problematic on powerpc platforms. Have you tested (at least compiled) for any of them (eg. T2080, T4240, P1022, MPC8536, etc.)?
York