Hi Alex,
On 19 November 2016 at 14:47, Alexander Graf agraf@suse.de wrote:
Am 19.11.2016 um 21:02 schrieb Simon Glass sjg@chromium.org:
Hi Alex,
On 19 November 2016 at 07:13, Alexander Graf agraf@suse.de wrote:
On 19/11/2016 14:48, Simon Glass wrote:
Hi Alex,
On 17 November 2016 at 10:31, Alexander Graf agraf@suse.de wrote:
Today we can compile a self-contained hello world efi test binary that allows us to quickly verify whether the EFI loader framwork works.
We can use that binary outside of the self-contained test case though, by providing it to a to-be-tested system via tftp.
This patch separates compilation of the helloworld.efi file from including it in the u-boot binary for "bootefi hello". It also modifies the efi_loader test case to enable travis to pick up the compiled file. Because we're now no longer bloating the resulting u-boot binary, we can enable compilation always, giving us good travis test coverage.
Signed-off-by: Alexander Graf agraf@suse.de
arch/arm/lib/Makefile | 2 +- arch/x86/config.mk | 2 +- arch/x86/lib/Makefile | 2 +- cmd/Kconfig | 15 ++++++++++++++- configs/qemu-x86_efi_payload64_defconfig | 1 + lib/efi_loader/Makefile | 3 +++ test/py/tests/test_efi_loader.py | 2 +- 7 files changed, 22 insertions(+), 5 deletions(-)
Ick.
Can you not achieve the same effect just by copying the file somewhere?
Sure, we could. But the file is only defined inside the env of the particular test case. So if you want to test against non-travis, you can copy it wherever you like.
This way the travis description simplifies a lot, because we can just expose the build directory as tftp root.
Or use .PRECIOUS on the existing file? You could copy it into the root directory of the build, perhaps? It just seems like a lot of extra stuff for a file that is already built.
I want to make sure that by default we never compile the hello world efi example into the u-boot binary, but still have the file build tested and available for travis.
So how about just having two cases:
1. Compile hello world and produce it as an output 2. As 1 but also build it into the U-Boot binary
The first one could be controlled by EFI_LOADER, the second with the existing option for the 'bootefi hello' command.
Regards, Simon