Bin Meng bmeng.cn@gmail.com 於 2018年12月12日 週三 下午5:37寫道：
Hi Rick,
On Wed, Dec 12, 2018 at 5:02 PM Rick Chen rickchen36@gmail.com wrote:
Hi Bin
Bin Meng bmeng.cn@gmail.com 於 2018年12月11日 週二 下午3:17寫道：
Hi Rick,
On Tue, Dec 11, 2018 at 3:06 PM Rick Chen rickchen36@gmail.com wrote:
Subject: [PATCH v2 06/20] riscv: ax25: Hide the ax25-specific Kconfig option
There is no need to expose RISCV_NDS to the Kconfig menu as it is an ax25-specific option.
Hi Bin
Can you explain why there is no need to expose RISCV_NDS here ?
This is specific to AX25, and there is no need to appear in the Kconfig menu when people are building U-Boot for some other RISC-V platforms. Also even if you select Y in the Kconfig menu for this option for platforms other than AX25, it just does not help since all its logic is within arch/riscv/cpu/ax25.
AX25 can not select RISCV_NDS by default, it may cause build fail problem. I still prefer to enable it by make menuconfig. Can you drop this patch ?
I prefer not to drop this patch since it's not supposed to be exposed to other platforms.
Do you mean the build fail problem is custom CSR numbers like mcache_ctl? Can we use hardcoded CSR number instead?
Thanks for your suggestion about hardcoded CSR number.
But actually I hope the mcache_ctl will be disabled by default in this stage. Because some drivers of ae350 (like spi, smc flash driver, mac driver) still have some access problems when cache is enable. I am fixing it now. But mmc driver is ready when cache is enable. That is why I prefer enable cache by make menuconfig. It will be easy to switch cache enable or disable by make menuconfig without modifying Kconfig.
How do you think about it ?
B.R Rick
Regards, Bin