Re: [U-Boot] [PATCH 30/55] dm: pmic: Display the regulator limits on error

Hello Simon,

On 07/03/2015 02:16 AM, Simon Glass wrote:

When a regulator command cannot honour the requested voltage, display the limits to try to be helpful.

Signed-off-by: Simon Glass sjg@chromium.org

common/cmd_regulator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/cmd_regulator.c b/common/cmd_regulator.c index 6149d1e..2d8579b 100644 --- a/common/cmd_regulator.c +++ b/common/cmd_regulator.c @@ -241,7 +241,8 @@ static int do_value(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])

value = simple_strtoul(argv[1], NULL, 0); if ((value < uc_pdata->min_uV || value > uc_pdata->max_uV) && !force) {

• printf("Value exceeds regulator constraint limits\n");
  

Could you please also add printing the 'uV' unit?

• printf("Value exceeds regulator constraint limits %d..%d\n",
  

•        uc_pdata->min_uV, uc_pdata->max_uV);
  

  return CMD_RET_FAILURE; }

Acked-by: Przemyslaw Marczak p.marczak@samsung.com

Regards