On Thu, 2011-08-25 at 23:20 +0200, Wolfgang Denk wrote:
Dear York Sun,
In message 1314305821.29220.21.camel@oslab-l1 you wrote:
WARNING: do not add new typedefs #408: FILE: arch/powerpc/include/asm/immap_83xx.h:289: +typedef struct ccsr_ddr {
Please fix.
I can fix the new tyepdef. But this one isn't. It has been used for a long time by 85xx. I am trying to unified the code. It is inevitable to define the same typedef for 83xx.
Is it? I don't think so. You can, for example, fix the 85xx code as well...
Fixing all existing reference to ccs_ddr is a lot of work, comparing with defining it for 83xx. There are many other typedefs in the very same files. Would we fix all of them? I don't think so. The bottom of line is ccsr_ddr is not a new typedef.
York