Re: [PATCH v4 07/20] x86: coreboot: Enable CONFIG_SYS_NS16550_MEM32

Hi Simon,

On Thu, Aug 24, 2023 at 5:11 AM Simon Glass sjg@chromium.org wrote:

The debug UART on modern machines uses a 32-bit wide transfer. Without this, setting debug output causes a hang or no output. It is not obvious (when enabling CONFIG_DEBUG_UART) that this is needed.

Enable 32-bit access to avoid this trap.

Signed-off-by: Simon Glass sjg@chromium.org

(no changes since v1)

configs/coreboot64_defconfig | 1 + configs/coreboot_defconfig | 1 + 2 files changed, 2 insertions(+)

Can we use CONFIG_NS16550_DYNAMIC?

Hardcode CONFIG_SYS_NS16550_MEM32 in the defconfig just works for one configuration like yours, but it fails on some other configurations, e.g.: IO port based ns16550.

Regards, Bin