On 09/25/2018 01:24 AM, Ooi, Joyce wrote:
This adds support for TSE PCS that uses SGMII adapter when the phy-mode in device tree is set to sgmii.
Can you add a bit more description to your commit message? TSE(Triple Speed Ethernet), but what is PCS?
Signed-off-by: Ooi, Joyce joyce.ooi@intel.com
drivers/net/Makefile | 3 +- drivers/net/designware.c | 5 ++ drivers/net/designware.h | 1 + drivers/net/dwmac_socfpga.c | 121 +++++++++++++++++++++++++ drivers/net/phy/altr_tse_pcs.c | 197 +++++++++++++++++++++++++++++++++++++++++ drivers/net/phy/altr_tse_pcs.h | 59 ++++++++++++ 6 files changed, 385 insertions(+), 1 deletion(-) create mode 100644 drivers/net/phy/altr_tse_pcs.c create mode 100644 drivers/net/phy/altr_tse_pcs.h
diff --git a/drivers/net/Makefile b/drivers/net/Makefile index 48a2878..c2333b5 100644 --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -14,7 +14,7 @@ obj-$(CONFIG_CALXEDA_XGMAC) += calxedaxgmac.o obj-$(CONFIG_CS8900) += cs8900.o obj-$(CONFIG_TULIP) += dc2114x.o obj-$(CONFIG_ETH_DESIGNWARE) += designware.o -obj-$(CONFIG_ETH_DESIGNWARE_SOCFPGA) += dwmac_socfpga.o +obj-$(CONFIG_ETH_DESIGNWARE_SOCFPGA) += dwmac-socfpga.o
Huh? What's this change for?
Also, I'm getting these compile errors against the latest U-Boot, top commit = "284b27cf81da10d55 Merge branch 'master' of git://git.denx.de/u-boot-mips" :
drivers/net/dwmac_socfpga.c: In function ‘socfpga_dw_tse_pcs_init’: drivers/net/dwmac_socfpga.c:67:9: warning: implicit declaration of function ‘mbox_get_fpga_config_status’ [-Wimplicit-function-declaration] ret = mbox_get_fpga_config_status(MBOX_CONFIG_STATUS); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ LD common/built-in.o LD drivers/net/dwmac-socfpga.o LD drivers/net/built-in.o LD cmd/built-in.o CC lib/smbios.o CC lib/display_options.o CC lib/efi_loader/efi_reloc.o CC lib/efi_loader/helloworld.o LD lib/efi_loader/helloworld_efi.so OBJCOPY lib/efi_loader/helloworld.efi rm lib/efi_loader/helloworld_efi.so lib/efi_loader/helloworld.o LD lib/built-in.o LD u-boot drivers/net/built-in.o: In function `dwmac_socfpga_ofdata_to_platdata': /home/dinguyen/linux_dev/u-boot/drivers/net/dwmac_socfpga.c:170: undefined reference to `syscon_node_to_regmap' /home/dinguyen/linux_dev/u-boot/drivers/net/dwmac_socfpga.c:177: undefined reference to `regmap_get_range' drivers/net/built-in.o: In function `socfpga_dw_tse_pcs_init': /home/dinguyen/linux_dev/u-boot/drivers/net/dwmac_socfpga.c:67: undefined reference to `mbox_get_fpga_config_status'
In the future, please test before submitting patches.
Thanks, Dinh