On Tue, Apr 12, 2011 at 8:44 PM, Mike Frysinger vapier@gentoo.org wrote:
On Tuesday, April 12, 2011 20:46:08 Simon Glass wrote:
+static int turbo_mode = 1;
perhaps this should be a #define ? i cant see anything that changes its value in this driver ...
OK, I have changed this to a compile-time option.
+static void smsc95xx_halt(struct eth_device *eth) +{
- debug("** %s()\n", __func__);
+}
is this right ? shouldnt you be halting something ?
I could do, but halting is not in the driver at present. Do you think it is important?
+/*
- SMSC probing functions
- */
+void smsc95xx_eth_before_probe(void) +{
- curr_eth_dev = 0;
+}
curr_eth_dev is declared static which means it starts off with a value of 0. when does before_probe get called ? just once ever during the execution of u- boot ? i guess this func should get tossed if that's the case.
It is called on a 'usb start'. I think we should keep it so people can call this repeatedly without problems.
Regards, Simon
-mike