
16 Jun
2014
16 Jun
'14
6:38 a.m.
Dear Otavio Salvador,
In message 1402879613-21362-5-git-send-email-otavio@ossystems.com.br you wrote:
When debugging initramfs failures it is quite useful to known where it is being loaded from.
Agreed.
printf(" ramdisk load start = 0x%08lx, ramdisk load end = 0x%08lx\n",
} else { *initrd_start = 0; *initrd_end = 0; }*initrd_start, *initrd_end);
- debug(" ramdisk load start = 0x%08lx, ramdisk load end = 0x%08lx\n",
*initrd_start, *initrd_end);
As you write yourself, this is a debug feature. There is no need to pollute normal output with such information. It just makes booting slower. So debug() is appropriate here.
And I don't see why you would NOT want to have the information in the else case.
I don't think this change is a good idea. It should not be applied.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
The past is not dead. In fact, it's not even past. - William Faulkner