30 Aug
2011
30 Aug
'11
9:58 p.m.
On Tuesday, August 30, 2011 15:52:38 Wolfgang Denk wrote:
Simon Glass wrote:
+#define CIRC_BUF_IDX(idx) ((idx) % CONFIG_PRE_CON_BUF_SZ)
The division here sticks in the craw, but unless we go with
Does it? Why?
CONFIG_PRE_CON_BUF_SZ_LOG2 then I don't see an easy way around it, and since this is serial output we can't honestly claim to worry much about performance.
Please see my previous posting (http://article.gmane.org/gmane.comp.boot-loaders.u-boot/106810)
I don't think 3 additional addembler instructions really play a big role here.
i'm pretty sure if you define CONFIG_PRE_CON_BUF_SZ as a power of 2 value, you get nice & simple assembly code. so if the generated code is undesirable, pick a CONFIG value that is power-of-2 ? -mike