In of_get_address(), there is:
dev_count_cells(dev, &na, &ns);
followed by:
bus->count_cells(dev, &na, &ns);
but no codes in between use na/ns, hence the first call is useless. By dropping the first call, dev_count_cells() is now useless too.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
---
Changes in v2: - new patch: of: addr: Remove call to dev_count_cells() in of_get_address()
drivers/core/of_addr.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/core/of_addr.c b/drivers/core/of_addr.c index a3af48fd88..3fbc0a7afa 100644 --- a/drivers/core/of_addr.c +++ b/drivers/core/of_addr.c @@ -118,11 +118,6 @@ static struct of_bus *of_match_bus(struct device_node *np) return NULL; }
-static void dev_count_cells(const struct device_node *np, int *nap, int *nsp) -{ - of_bus_default_count_cells(np, nap, nsp); -} - const __be32 *of_get_address(const struct device_node *dev, int index, u64 *size, unsigned int *flags) { @@ -136,7 +131,6 @@ const __be32 *of_get_address(const struct device_node *dev, int index, parent = of_get_parent(dev); if (parent == NULL) return NULL; - dev_count_cells(dev, &na, &ns); bus = of_match_bus(parent); bus->count_cells(dev, &na, &ns); of_node_put(parent);