Hi Stefano,
On Tue, Feb 21, 2012 at 9:15 AM, Stefano Babic sbabic@denx.de wrote:
On 21/02/2012 18:06, Mike Frysinger wrote:
On Tuesday 21 February 2012 05:20:47 Stefano Babic wrote:
I will try myself with mips, as this is one of the architectures reporting warnings.
i don't think Simon did say that mips was throwing these warnings, so testing that arch and looking for these warnings won't help
Part of the problem is that I mislabeled the commits, claiming that I was using a 4.6 compiler when in fact mostly it was 4.4.4.
In the thread I read that Simon got warnings with both mips and powerpc, as well as with avr32 and m68k. But mips and powerpc are free of warnings when I build with gcc 4.6.
Yes but not just those. There are detailed notes with each patch, but here is a summary. I think 6 out of 9 patches should be applied regardless of toolchain.
68k only: arch/m68k/lib/board.c | 2 +- - I believe this fix is sensible for the reasons described in the patch, regardless of what the toolchain does.
PPC only: arch/powerpc/cpu/mpc5xxx/usb_ohci.c | 79 ++++++++++++++++++++-------------- arch/powerpc/cpu/ppc4xx/usb_ohci.c | 81 ++++++++++++++++++++-------------- - These two seem not to happen with a later toolchain. Please skip these if you like.
arch/powerpc/lib/board.c | 7 +-- - Similar to the68k patch, again I think it makes sense to apply this. The variable is unsigned char for no good reason.
Sandbox: arch/sandbox/cpu/os.c | 11 +++-- - This should be applied as it is not toolchain dependent (Mike may have picked it up already)
common/dlmalloc.c | 8 ++-- - These happen with MIPS, AVR, 68k for me (with Mike's toolchains). Does not happen on 4.6 ARM.
ARM and PPC: drivers/usb/host/ohci-hcd.c | 26 ++++++------ - These happen with my 4.4.4 compiler, apparently not on 4.6. Drop them if you like.
ARM: include/configs/snapper9260.h | 1 - - This fixes a real problem regardless of toolchain.
Regards, Simon
Stefano
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================