Re: [U-Boot] [PATCH 2/3] Add generic bit operations

On 12:27 Thu 04 Jun , Daniel Mack wrote:

This adds generic bit operations for all platforms and enables includes the implementations from asm-arm.

Code taken from Linux kernel.

the __set_bit, __clear_bit, __change_bit & co generic is used on arm ok

but be aware that we use it in U-Boot so NACK

and please do not rename __xxx by xxx they do not mean the same think

the __xxx can be re-ordered and the xxx not

IMHO please keep the linux naming to simplify think in the futur and please specify which file it's import and which kernel version

Best Regards, J.