On Thu, Aug 20, 2020 at 03:36:31PM +0200, Marek Vasut wrote:
On 8/20/20 3:26 PM, Simon Glass wrote:
On Fri, 7 Aug 2020 at 08:43, Sean Anderson seanga2@gmail.com wrote:
This allows different log levels to be enabled or disabled depending on the desired level of verbosity. In particular, it allows for general debug information to be printed while excluding more verbose logging which may interfere with timing.
Signed-off-by: Sean Anderson seanga2@gmail.com
Changes in v2:
- New
drivers/spi/designware_spi.c | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-)
Reviewed-by: Simon Glass sjg@chromium.org
NAK, please use dev_dbg() instead.
For the record, Marek and I (and Sean) had talked a bit on IRC. These messages being log_xxx() and not dev_xx() instead make the more functionally useful as dev_xxx() converts to printf() and messes with the timing. log_xxx() puts them in the buffer and will not break the timing. Marek objects to the fundamentals that dev_xxx() does not function like it does in Linux (and please correct me if you feel I'm mis-representing your views). This could be solved by plumbing dev_xxx() to use log_xxx() if LOG is enabled automagically. I don't see transitions like that as blocking for this patch, Marek does.