Hi Urja,
On Fri, 26 Apr 2019 at 04:26, Urja Rannikko urjaman@gmail.com wrote:
Hi Simon,
On Wed, Apr 24, 2019 at 3:54 AM Simon Glass sjg@chromium.org wrote:
Hi Urja,
<snip> > > Could we add a Kconfig to control this? Other devices shouldn't have this code. I suppose i can do that... but I will need to know all the devices that do this - I'd assume atleast jerry, minnie and speedy but maybe also rk3399 chromeos devices?
I'm thinking basically an ifdef around the check in is_gpt_valid and let gcc optimize the rest of the code (test for 2) out, and then
How about a new 'SUPPORT_CHROMEOS' Kconfig which implies your new CONFIG below? You could enable it on configs/*chrome*
See if you can use
if (IS_ENABLED(CONFIG_xx))
instead of #ifdef.
select the Kconfig (ummm maybe CONFIG_IGNORE_CROS_IGNOREME_GPT or do
Maybe just CONFIG_CROS_GPT.
you have better ideas?) for the appropriate boards.
-- Urja Rannikko
Regards, Simon