Andrew Dyer wrote:
--- drivers/cfi_flash.c 17 Nov 2006 09:02:43 -0000 1.2 +++ drivers/cfi_flash.c 20 Nov 2006 03:41:43 -0000 1.3 @@ -1107,7 +1107,12 @@ ulong flash_get_size (ulong +#ifndef CONFIG_S29GL064M info->write_tout = (tmp * (1 << flash_read_uchar (info, FLASH_OFFSET_WMAX_TOUT))) / 1000; +#else
- info->write_tout = 1; /* Suggested by Tolunay */
+#endif /* CONFIG_S29GL064M */
Instead of a chip specific solution we should try to find more generalized solution. At minimum, we could always use 1 if the value turns out to be 0 after calculation.
I think we had a long e-mail exchange about this problem in may of '05 some of which is here:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/17379
it looks like a fix never got committed (at least as of the last time I pulled from git which was admittedly a while ago).
Thanks Andew for jogging my memory. I now remember that discussion and actually I did submit a patch which was committed. It is in the git. I just checked it. It was committed Feb 28, 2006
http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=79b4cda076...
Sam you said this in your original mail:
What could be the problem be? I use the CFI driver from GIT repository on Nov. 2.
Sam please do sync up with the git and please make sure you do have latest code next time.
Best regards, Tolunay