Re: [U-Boot-Users] [PATCH] OMAP1610 cs boot mode

In message 0F6832DAA2EE0B4D9281EDC36F09A8FC0FB1D9@esebe025.ntc.nokia.com you wrote:

...

Thanks, added - except for the part which modifies common/env_flash.c

Here, instead of simply initializing the relevant variables at compile time, you added code to do this at run time. I don't think this is a good idea. Please explain why you are doing this, and which problem you attempt to fix.

It needs to be done in runtime since CFG_FLASH_BASE is defined as a variable when one of the new targets is selected:

Did you actually test this on other hardware?

My concern is: the first access to trhe environment happen long before relocation to RAM, and during this phase we don't have a writable data segment.

Best regards,

Wolfgang Denk