Re: [U-Boot] [PATCH 1/2] Add support for Eukrea CPU9260 SBC

Dear Eric Benard,

In message 1247948834-30856-1-git-send-email-eric@eukrea.com you wrote:

CPUAT91 is built around Atmel's AT91SAM9260 and has up to 64MB of NOR flash, up to 128MB of SDRAM, up to 2GB of NAND and includes a 10/100 Ethernet PHY in RMII mode.

...

--- a/Makefile +++ b/Makefile @@ -2813,6 +2813,19 @@ at91sam9rlek_config : unconfig fi; @$(MKCONFIG) -a at91sam9rlek arm arm926ejs at91sam9rlek atmel at91

+cpu9260_64m_config \ +cpu9260_config : unconfig

• @$(MKCONFIG) -a cpu9260 arm arm926ejs cpu9260 eukrea at91
• @if [ "$(findstring _64m,$@)" ] ; then \

• echo "#define CONFIG_SYS_SDRC_CR_VAL CONFIG_SYS_SDRC_CR_VAL_64MB" \
  

• 	>>$(obj)include/config.h ; \
  

• $(XECHO) "... with 64MB SDRAM" ; \
  

• else \

• echo "#define CONFIG_SYS_SDRC_CR_VAL CONFIG_SYS_SDRC_CR_VAL_128MB" \
  

• 	>>$(obj)include/config.h ; \
  

• $(XECHO) "... with 128MB SDRAM" ; \
  

• fi;

This makes no sense to me. "mkconfig -a" (i. e. in append mode) should be used AFTER manually initializing the config files. Either omit the "-a", or move the line down.

Best regards,

Wolfgang Denk