Wolfgang,
Yes indeed I duplicated cfi_flash.c. The changes in my previous patch to CFI were rejected. You indicated see the previous list mail on the subject. Your assertion at that time was to put things into the board specific files was one way to go.
The patch I had at that time was ifdef'ed just for my board in CFI and for the flash part I'm using would seem to show errors. I think those OMAP specific ifdef's may fix errors, but I being its such a highly coupled driver it is very difficult to add in changes with out breaking a lot of boards. How do you suggest real integration into that driver? The 1% changes are minor and isolated now and that's not acceptable what is?
I certainly can break the patch into parts, but they are all coupled. The chip and board are very new have went though flux and this results in large patches at this time. This is not a PPC821 which shouldn't have a lot of change.
Best Regards, Richard Woodruff
-----Original Message----- From: wd@denx.de [mailto:wd@denx.de] Sent: Wednesday, September 28, 2005 6:46 PM To: Woodruff, Richard Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [PATCH] Update OMAP242x for git head (plus sign).
In message
EA12F909C0431D458B9D18A176BEE4A50246905D@dlee02.ent.ti.com
you wrote:
- Patch by Richard Woodruff, 28 Sep 2005:
OMAP242x H4 board update
- Switch to private cfi_flah.c file.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
- Make work for 2422 mono-ddr.
- Make work for 2420-POP.
- Use clock gauging to determine crystal speed.
- Fix warm reset problem with bad OTGCTRL access.
- Switch to DDR unlock mode operation for DLL errata.
- Remove obsolete APTIX conditionals.
- Display more information at startup.
- Use 24XX instead of 2420 in prep for future chips.
I reject this patch. You duplicate the common drivers/cfi_flash.c file (1269 lines) with less than 1% modifications into a board specific file (board/omap2420h4/cfi_flash.c).
This is not acceptable.
Also, your patch is much too big. Please break it down into digestable chunks. Please see the README, and re-read my posting http://sourceforge.net/mailarchive/message.php?msg_id=12658390
In short:
Make separate commits for logically separate changes.
Best regards,
Wolfgang Denk
-- Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Many aligators will be slain, but the swamp will remain.