Re: [PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

On Fri, Feb 16, 2024 at 04:11:05PM +0530, Siddharth Vadapalli wrote:

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index eea9ec9659..8a6625f034 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -1770,9 +1770,11 @@ static int udma_probe(struct udevice *dev) return PTR_ERR(ud->ringacc);

ud->dev = dev;

• ud->ch_count = setup_resources(ud);
• if (ud->ch_count <= 0)

• return ud->ch_count;
  

• ret = setup_resources(ud);
• if (ret <= 0)

• return ret;
  

The code was like this originally, but setup_resources() can't actually return zero so it would be nicer to say: ret = setup_resources(ud); if (ret < 0) return ret;

regards, dan carpenter

• ud->ch_count = ret;