6 Feb
2019
6 Feb
'19
10:35 a.m.
On 06/02/2019 03:31, Joe Hershberger wrote:
/cut
Perhaps the default can be to attempt to auto select, but if it is ambiguous, require the explicit specification. It could follow a similar approach to the "md" command. We can add the ability to add ".22" and ".45" to the mdio command to explicitly select.
What about we go back to have a generic phy_{r|w}_mmd() and (in this order):
1) If the PHY driver is defining a generic {r|w}_mmd() hook we use that. 2) We do direct C45 access if (phy_driver->features & PHY_10G_FEATURES) 3) We do direct C22 access if (devad == MDIO_DEVAD_NONE) 4) We do indirect C22 access to C45 in all the other cases
Se we can have one single "mdio" command for all the cases.
-- Carlo Caione