Re: [U-Boot] [PATCH 2/2] ARM: OMAP5: redefine arm_setup_identity_mapping

On Mon, Nov 19, 2012 at 03:59:34PM +0100, Vincent Stehlé wrote:

We introduce an OMAP5 specific version of arm_setup_identity_mapping(), which makes the first page of the identity mapping invalid.

We want to unmap the region near address zero on HS OMAP devices, to avoid speculative accesses. Accessing this region causes security violations, which we want to avoid.

Signed-off-by: Vincent Stehlé v-stehle@ti.com

[snip]

• /* Perform default mapping, which sets up an identity-mapping for all

• * 4GB, rw for everyone */
  

/* * Multi-line comments must all be like this. */

Aside from that (and the comment to 1/2) I think we're good here, including the naming of the function. Thanks!