Re: [PATCH] usb: gadget: dwc2_udc_otg: Fix dwc2_gadget_start()

On 2/17/21 9:57 AM, Patrice CHOTARD wrote:

Hi Marek

Hi,

[...]

...

...

@@ -319,12 +318,11 @@ static int dwc2_gadget_start(struct usb_gadget *g,       struct dwc2_udc *dev = the_controller;         debug_cond(DEBUG_SETUP != 0, "%s: %s\n", __func__, "no name");         if (!driver || -        (driver->speed != USB_SPEED_FULL && -         driver->speed != USB_SPEED_HIGH) || +        driver->speed < USB_SPEED_FULL ||

The DWC2 can't operate in LS gadget mode , i.e. emulate some old keyboard ? Maybe what you want is driver->speed > USB_SPEED_HIGH instead ?

The test is correct, in case driver->speed is lower than FS, we return -EINVAL. All others speed FS/HS/SS and higher are allowed.

What's the problem with LS ?

[...]