Hi Wolfgang,
On Thu, Nov 10, 2011 at 01:01:59PM +0100, Wolfgang Denk wrote:
Dear Simon Guinot,
In message 20111110110608.GB29864@kw.sim.vm.gnt you wrote:
Let's remove this broken code.
This is exactly part of this patch ([PATCH] mvgbe: remove setting of ethaddr within the driver). This part, while ACK'ed by Mike, was NAK'ed by Prafulla.
As some boards are relying on this broken code, maybe you should provide an alternative ? I could be wrong, but it seems to me that just removing the code is not enough.
Which exact boards are these? And how exactly are these relying on the broken code?
I can't list this boards exactly. For sure, I can say that the LaCie boards (netspace_v2 and cie) are concerned.
For this boards a random MAC address is used and the computation is performed by the driver mvgbe. If this code is simply removed, the network initialization for this boards will break.
I suspect a lot of Marvell boards from being in the same case.
Regards,
Simon