Hi Kever,
On Fri, May 22, 2020 at 8:45 AM Kever Yang kever.yang@rock-chips.com wrote:
Hi Jagan,
On 2020/5/10 上午12:56, Jagan Teki wrote:
Due to board limitation some SSD's would work on rock960 PCIe M.2 only with 1.8V IO domain.
So, this patch enables grf io_sel explicitly to make PCIe/M.2 to work.
Cc: Tom Cubie tom@radxa.com Signed-off-by: Jagan Teki jagan@amarulasolutions.com Acked-by: Manivannan Sadhasivam manivannan.sadhasivam@linaro.org
Changes for v3:
collect mani a-b
add comments
board/vamrs/rock960_rk3399/rock960-rk3399.c | 23 +++++++++++++++++++++ configs/rock960-rk3399_defconfig | 5 +++++ 2 files changed, 28 insertions(+)
diff --git a/board/vamrs/rock960_rk3399/rock960-rk3399.c b/board/vamrs/rock960_rk3399/rock960-rk3399.c index 68a127b9ac..ef1eb2d0b7 100644 --- a/board/vamrs/rock960_rk3399/rock960-rk3399.c +++ b/board/vamrs/rock960_rk3399/rock960-rk3399.c @@ -2,3 +2,26 @@ /*
- Copyright (C) 2018 Manivannan Sadhasivam manivannan.sadhasivam@linaro.org
*/
+#include <common.h> +#include <syscon.h> +#include <asm/io.h> +#include <asm/arch-rockchip/clock.h> +#include <asm/arch-rockchip/grf_rk3399.h> +#include <asm/arch-rockchip/hardware.h>
+#ifdef CONFIG_MISC_INIT_R +int misc_init_r(void) +{
struct rk3399_grf_regs *grf =syscon_get_first_range(ROCKCHIP_SYSCON_GRF);/*** Some SSD's to work on rock960 would require explicit* domain voltage change, so BT565 is in 1.8v domain*/rk_setreg(&grf->io_vsel, BIT(0));
- rk_setreg(&grf->io_vsel, BIT(0));
^+arch/arm/include/asm/io.h:118:34: note: in definition of macro ‘writel’
- #define writel(v,c) ({ u32 __v = v; __iowmb(); __arch_putl(__v,c); __v; })
^+board/vamrs/rock960_rk3399/rock960-rk3399.c:23:2: note: in expansion of macro ‘rk_setreg’
- ^~~~~~~~~
+board/vamrs/rock960_rk3399/built-in.o: In function `misc_init_r': +board/vamrs/rock960_rk3399/rock960-rk3399.c:23: undefined reference to `BIT' +make[1]: *** [u-boot] Error 139
Did you get this error when build the code?
Sorry, I have forgotten to commit bitops header, will send this patch alone for the next version.
Jagan.