On 4/16/24 18:19, Heinrich Schuchardt wrote:
On 16.04.24 18:06, Tom Rini wrote:
On Tue, Apr 16, 2024 at 08:55:19AM +0200, Michal Simek wrote:
Convert UTF-8 chars to ASCII in cases where make sense. No Copyright or names are converted.
Signed-off-by: Michal Simek michal.simek@amd.com
Reviewed-by: Tom Rini trini@konsulko.com
Now, how did you test / find these? Given names a CI test is unlikely to be doable but if it's otherwise scriptable I can put it in my loops and just fixup as needed (like I do today for adding <common.h> for example).
There seem no to be too many non-ASCI strings outside of comments. Should we care about non-ASCII comments?
$ find . -name '*.h' -exec grep -P -Hn "[^\x00-\x7F]" {} ; | grep -v ':\s*[/*'] ./include/configs/tec-ng.h:13:#define CFG_TEGRA_BOARD_STRING "Avionic Design Tamonten™ NG Evaluation Carrier" ./arch/mips/mach-octeon/include/mach/cvmx-pko3.h:369: MEMALG_SUB = 9, /* mem = mem – PKO_SEND_MEM_S[OFFSET] */
$ find . -name '*.c' -exec grep -P -Hn "[^\x00-\x7F]" {} ; | grep -v ':\s*[/*'] ./drivers/mtd/nand/raw/nand_ids.c:65: {"H27QCG8T2E5R‐BCF 64G 3.3V 8-bit", ./drivers/video/dw_mipi_dsi.c:861:MODULE_AUTHOR("Yannick Fertré yannick.fertre@st.com"); ./board/bosch/acc/acc.c:440: .SRT = 0, // Set to 1 for temperatures above 85°C ./cmd/2048.c:65: printf(" · "); ./cmd/2048.c:79: printf(" ←, ↑, →, ↓ or q \n");
I actually use more force way and simply run uni2ascii -B < file to all files and then look at git diff and pick what it is valid. Above find is not able to find all that strings.
For example this one could be also fixed which above filter it not able to find.
--- a/include/mtd/ubi-user.h +++ b/include/mtd/ubi-user.h @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* - * Copyright © International Business Machines Corp., 2006 + * Copyright (c) International Business Machines Corp., 2006
M