Hi Simon,
Hi Lukasz,
On 4 April 2014 04:09, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Marek,
On Thursday, April 03, 2014 at 09:01:30 PM, Tom Rini wrote:
On Thu, Apr 03, 2014 at 11:35:10AM -0600, Simon Glass wrote:
Hi Marek,
On 3 April 2014 11:03, Marek Vasut marex@denx.de wrote:
On Friday, March 28, 2014 at 10:16:42 PM, Tom Rini wrote: > On Sat, Mar 22, 2014 at 05:14:51PM -0600, Simon Glass > wrote: > > We should move forward to remove the old board init > > code. Add a prominent message to encourage maintainers > > to get started on this work. > > > > Signed-off-by: Simon Glass sjg@chromium.org > > Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even worse, all boards now generate this warning and I'm worried that this will cause the more attentive maintainers to take action and produce fast fixes which won't receive sufficient testing until release is out.
I seriously disagree with applying the patch for current release.
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
So, Marek and I were discussing this on IRC as well. Given about a year and nothing converted (except for new things) I opted for the noisier approach. It really is a simple switch
Unfortunately, it isn't a simple switch in my case.
The +#define CONFIG_SYS_GENERIC_BOARD on the trats2 (and probably also trats) board causes problem with power management initialization. I will not be able to fix this and validate before v2014.04.
This issue will be fixed after the release.
FWIW this works OK on exynos5 which has used generic board for a while. I'm not sure what the problem is - I don't see a change in the ordering of the call to power_init().
I've observed strange behaviour when battery was removed. I need time to investigate it.
Frankly, I plan to look closer on the power system after the release of v2014.04.
Regards, Simon