Hi,
On 11/08/2011 01:47 PM, Wolfgang Denk wrote:
env import [-t | -b | -c] [-s size] addr [var ...]
This also greatly simplifies the implementation.
Totally agree. Question is: won't that break all the existing scripts???
Yes. It _is_ an incompatible change of the API. I hate it, but mostly because I didn't chose such a format right from the beginning.
My hope is that probably not too many people use these features in scripts - at least so far it's only omap3_beagle and omap3_mvblx that use "env import -t $loadaddr $filesize". It is IMO better to change this now, instead of waiting until we have more users and the problem hits us in another place, hard.
we use it too in keymile-common.h and in the scripts we load with this command e.g. board/keymile/scripts/develop-ppc_82xx.txt
The resulting incompatibility is indeed not very nice. I don't see big issues for the command line and keymile-common.h where we can live with different API for different u-boot versions. But the usage in the scripts directory is more complicated, because then we have to make sure that uboot version x loads scripts x and u-boot version y loads scripts y. Ok we could prepare a second scripts directory e.g. "scripts_v2" or similar in addition to the current scripts directory in tftpboot, but this is not very nice.
Best regards Holger