Hi Alex,
On 02/23/2012 07:13 PM, Alex Hornung wrote:
Hi Graeme,
On 21/02/12 10:33, Graeme Russ wrote:
Hi Alex,
On 02/21/2012 10:45 AM, Alex Hornung wrote:
Adjust the GBL_DATA_OFFSET to account for the fact that we'll be using the space between that offset and the start of the malloc region to allocate both a gd structure and a board info structure.
This fixes a memory corruption bug due to overlap of the malloc region and the bd_info structure.
Signed-off-by: Alex Hornung alex@alexhornung.com
include/configs/nios2-generic.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
[snip]
And for the sake of one more copy and pointer adjustment, even gd could be moved into bss which would save all the hackish calculations of sticking gd and bd in a magic void below the stack
But maybe that's a battle for another day...
To be honest I just started using u-boot, and for that matter, just started using Nios2. I just ran across the issue and had to fix it to get u-boot working on my system.
Nonetheless I'd generally agree that less hackery is a better idea, and putting it in BSS is a good option - but reality is, as you point out, that most other platforms don't do that, either. For now I think the above patch should do.
I agree - as I said, a battle for another day :)
Regards,
Graeme