On 13/09/10 22:04, Ben Gardiner wrote:
This patch proposes to migrate the davinci_emac driver to using the eth_device->write_hwaddr function pointer as suggested by Ben Warren.
All the davinci boards had the behaviour, prior to this patch, of sync'ing the environment variable enetaddr with the MAC address read from non-volatile storage on boot -- when the two locations disagreed, the environment variable value took precendence. This patch keeps the same behaviour but makes eth_initialize take care of it.
This patch refactors davinci_emac setup in the boards so that the MAC address is read from non-volatile storage into the environment variable and then the environment variable value is use in eth_intialize. The only exception is the direct call to davinci_eth_set_mac_addr made by the da830evm board init which was changed into an assignment of the enetaddr field.
Signed-off-by: Ben Gardiner bengardiner@nanometrics.ca CC: Ben Warren biggerbadderben@gmail.com CC: Nick Thompson nick.thompson@ge.com
This change seem reasonable to me from the da830evm point of view. I don't have access to hardware for the next week or so, so I can't test it now, but the da830 specific changes are minor.
Reviewed-by: Nick Thompson nick.thompson@ge.com