Dear Simon Glass,
In message 1314633910-8550-3-git-send-email-sjg@chromium.org you wrote:
If puts() or printf() is called before the console is ready, U-Boot will either hang or die. This adds a check for this so that debug() can be used in early code without concern that it will hang.
U-Boot boots properly
Tested-by: Simon Glass sjg@chromium.org Signed-off-by: Simon Glass sjg@chromium.org
common/console.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Isn't this just hushing up implementation errors?
Before, the incorrect call would cause U-Boot to fail - a situation which cannot be overlooked during the port, so the problem will quickly be analyzed and fixed.
With your commit, everything appears to work fine, just some (expected) output will be missing. This is misleading at beats, and will cause that buggy code will go undetected for a long time.
I don't think this is a good strategy.
Please comment.
Best regards,
Wolfgang Denk