hi tom,
thanks for your review!
El Sun, Jan 17, 2010 at 09:25:52AM -0600 Tom ha dit:
Matthias Kaehlcke wrote:
Add support for the Cirrus EP93XX platform
Signed-off-by: Matthias Kaehlcke matthias@kaehlcke.net
cpu/arm920t/ep93xx/Makefile | 56 ++++ cpu/arm920t/ep93xx/cpu.c | 51 +++ cpu/arm920t/ep93xx/led.c | 63 ++++ cpu/arm920t/ep93xx/led.h | 26 ++ cpu/arm920t/ep93xx/lowlevel_init.S | 65 ++++ cpu/arm920t/ep93xx/speed.c | 109 ++++++ cpu/arm920t/ep93xx/timer.c | 157 +++++++++ cpu/arm920t/ep93xx/u-boot.lds | 59 ++++ include/asm-arm/arch-ep93xx/ep93xx.h | 596 ++++++++++++++++++++++++++++++++++ 9 files changed, 1182 insertions(+), 0 deletions(-) create mode 100644 cpu/arm920t/ep93xx/Makefile create mode 100644 cpu/arm920t/ep93xx/cpu.c create mode 100644 cpu/arm920t/ep93xx/led.c create mode 100644 cpu/arm920t/ep93xx/led.h create mode 100644 cpu/arm920t/ep93xx/lowlevel_init.S create mode 100644 cpu/arm920t/ep93xx/speed.c create mode 100644 cpu/arm920t/ep93xx/timer.c create mode 100644 cpu/arm920t/ep93xx/u-boot.lds create mode 100644 include/asm-arm/arch-ep93xx/ep93xx.h
There are build errors that cut this review short. The review of this patch is fairly complete. I will review the others on the next revision.
For the ep93xx boards, I saw this error on MAKEALL and building normally
src/u-boot-arm/drivers/net/ep93xx.c:513: undefined reference to `unlikely' drivers/net/libnet.a(ep93xx.o): In function `ep93xx_miiphy_write'
i forgot that i have an additional patch in my tree that fixes this issue
as it isn't related with ep93xx in any way i sent it separately:
http://lists.denx.de/pipermail/u-boot/2009-December/065779.html
what is the right way to solve this dependency on a patch that isn't in mainline yet? add it to the patch set though it isn't ep93xx related?
i'll comment/resolve the other issues you raised at a later point