Re: [U-Boot] [PATCH] panic: add noreturn attribute

Dear Mike Frysinger,

In message 20110726145430.3E637138EED4@gemini.denx.de I wrote:

In message 1309384684-26415-1-git-send-email-vapier@gentoo.org you wrote:

...

Since panic() never returns, we should add an appropriate attribute to let gcc improve optimization around it.

Signed-off-by: Mike Frysinger vapier@gentoo.org

include/common.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Arghh... this is causing build warnings for ALL boards:

vsprintf.c: In function 'panic': vsprintf.c:730: warning: 'noreturn' function does return

Please fix!

[Did you not test this??]

Best regards,

Wolfgang Denk