
Dear Lukasz Majewski,
In message 20120416112308.00700f08@lmajewski.digital.local you wrote:
I'm a bit confused about the policy with porting files:
http://www.denx.de/wiki/U-Boot/Patches
This says clearly: document from where the code comes from. I wanted to show from where the file has been taken.
This is perfectly fine.
Those files doesn't compile as is, but no one enabled them in u-boot, so code is still bisectable.
You must not expect that Linux kernel code can be used _unchanged_ for U-Boot's purposes. Adding a ton of #defines that make no sense in U-Boot context at all is misleading at best.
For me it would be even better to provide one commit providing composite driver :-), but I wanted to stick to the policy.
Please strip down the driver and remove the parts that do not fit.
Best regards,
Wolfgang Denk