Hi Luca,
Le 14/04/2011 17:52, Luca Ceresoli a écrit :
A note about checkpatch.pl.
:)
Some of these patches do have checkpatch errors and/or warnings. These are all issues that were already present in the pre-existing code. An example from patch 2:
static void -PingHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len) +PingHandler (uchar * pkt, unsigned dest, IPaddr_t sip, unsigned src, +unsigned len) {
Raises:
- ERROR: "foo * bar" should be "foo *bar"
- WARNING: space prohibited between function name and open parenthesis '('
As I didn't touch the pointer parameters nor the stuff before the '(' (but I changed the line somewhere else), should I also fix the checkpatch issues? And in case, should it be a separate patch to make it cleaner?
My opinion is that you should make sure that at least the code you touch is checkpatch-clean, so yes, you should fix that; but there is no need to submit 'checkpatch-compliance' patches. Just fix the line here so that checkpatch does not complain.
Amicalement,